Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FP-1564: Update Core-CMS Dependencies #471

Merged
merged 10 commits into from
Mar 25, 2022
Merged

FP-1564: Update Core-CMS Dependencies #471

merged 10 commits into from
Mar 25, 2022

Conversation

taoteg
Copy link
Collaborator

@taoteg taoteg commented Mar 23, 2022 •
edited
Loading

Overview

Update for execution environments and multiple dependency vulnerabilities in back and front end.
Added engine setting to specify node version targeted in container.

Related

Required By || Requires

  • N/A

Changes

Environment Updates:

  • Python 3.8.12
  • Node v17.8.0
  • npm 8.5.5

Python packages:

  • Django = "2.2.16" --> Django = "2.2.27"
  • Pillow = "9.0.0" --> Pillow = "9.0.1"
  • lxml = "4.5.2" --> lxml = "4.6.5"
  • urllib3 = "1.25.10" --> urllib3 = "1.25.11"
  • python-ldap = "3.3.1" --> python-ldap = "3.4.0"

JavaScript packages:

  • Removed a large number of outdated and unused transient dependencies, updated those remaining.
  • Added engine definition with node and npm versions.
  • Updated dev-dependencies:
    • cssnano@4.1.10 --> cssnano@5.1.5
    • postcss-cli@7.1.2 --> postcss-cli@9.1.0
    • postcss-css-variables@0.17.0 --> postcss-css-variables@0.18.0
    • postcss-import@12.0.1 --> postcss-import@14.1.0
    • postcss-preset-env@6.7.0 --> postcss-preset-env@7.4.3
  • Added dev-dependencies:
    • postcss@8.4.12

Testing

  1. Upgrade your Node version to 17.x.
  2. Build and run project as usual.

Screenshots

  • N/A

Notes

  • None.

@taoteg taoteg marked this pull request as draft March 23, 2022 23:57
@taoteg taoteg changed the title Task/fp 1564 update corecms dependencies FP-1564 Update Core-CMS Dependencies Mar 23, 2022
@taoteg taoteg changed the title FP-1564 Update Core-CMS Dependencies FP-1564: Update Core-CMS Dependencies Mar 23, 2022
taoteg added 2 commits March 24, 2022 13:57
@taoteg
Removed the yarn.lock file as it is out of date and we are not yet tr…
6f9ac1a 
…ansitioning to yarn. Ran npm audit on current setup and updated dependencies. Tested building and running poortal from scratch succesfully. Still a few Moderate issues, going to try to update those now.
@taoteg
Upgraded Node, npm and all devdependencies.
ff32344
wesleyboar
wesleyboar reviewed Mar 24, 2022
View reviewed changes
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally. Node updates do not affect CSS output.

I tested remotely. Core & Frontera build and deploy well.

I would approve, but this PR is a draft, so I'll wait.

Core Frontera
build #494 build #495
deploy #1225 deploy #1226
dev server dev server

@taoteg taoteg marked this pull request as ready for review March 24, 2022 23:54
@taoteg @wesleyboar
Update Dockerfile
4dc8ceb 
yep!

Co-authored-by: W. Bomar <62723358+tacc-wbomar@users.noreply.github.com>
@taoteg taoteg requested a review from wesleyboar March 24, 2022 23:56
wesleyboar
wesleyboar approved these changes Mar 25, 2022
View reviewed changes
@taoteg
Update package.json
c97fc13 
Typo in description.
@taoteg taoteg merged commit 10fca2c into main Mar 25, 2022
@taoteg taoteg deleted the task/FP-1564-update-corecms-dependencies branch March 25, 2022 17:49
wesleyboar added a commit that referenced this pull request Mar 26, 2022
@wesleyboar
chore(fix): use new core-styles main branch
f0e654f 
This new main branch HEAD does not integrate changes from #471.

Those changes are BREAKING ONLY for core-cms using core-styles.

The changes are NOT BREAKING for core-cms before core-styles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyboar wesleyboar wesleyboar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taoteg @wesleyboar